router icon indicating copy to clipboard operation
router copied to clipboard

Proposal to make licensing terminology more generic

Open lambertjosh opened this issue 10 months ago • 6 comments

Apollo may add, change, or remove various pricing plans at some point in the future.

We should either:

  1. Define "Enterprise license" to be specifically the features which require a license of some kind
  2. Use a more general term for these features/licenses, such as "commercial" license as they are not available in OSS

This PR is a first draft at the latter route, change some references of Enterprise license to Commercial license, or in some cases just licensed features.


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • [ ] Changes are compatible[^1]
  • [ ] Documentation[^2] completed
  • [ ] Performance impact assessed and acceptable
  • Tests added and passing[^3]
    • [ ] Unit Tests
    • [ ] Integration Tests
    • [ ] Manual Tests

Exceptions

Note any exceptions here

Notes

[^1]: It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. [^2]: Configuration is an important part of many changes. Where applicable please try to document configuration examples. [^3]: Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

lambertjosh avatar Jan 15 '25 20:01 lambertjosh

⚠️ Docs preview not attached to branch

The preview was not built because the PR's base branch main is not in the list of sources.

An Apollo team member can comment one of the following commands to dictate which branch to attach the preview to:

  • !docs set-base-branch 1.x
  • !docs set-base-branch dev

Build ID: 321cb07763decacf5226cc84

svc-apollo-docs avatar Jan 15 '25 20:01 svc-apollo-docs

CI performance tests

  • [ ] connectors-const - Connectors stress test that runs with a constant number of users
  • [x] const - Basic stress test that runs with a constant number of users
  • [ ] demand-control-instrumented - A copy of the step test, but with demand control monitoring and metrics enabled
  • [ ] demand-control-uninstrumented - A copy of the step test, but with demand control monitoring enabled
  • [ ] enhanced-signature - Enhanced signature enabled
  • [ ] events - Stress test for events with a lot of users and deduplication ENABLED
  • [ ] events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • [ ] events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • [ ] events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • [ ] events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • [ ] events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • [ ] extended-reference-mode - Extended reference mode enabled
  • [ ] large-request - Stress test with a 1 MB request payload
  • [ ] no-tracing - Basic stress test, no tracing
  • [ ] reload - Reload test over a long period of time at a constant rate of users
  • [ ] step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • [ ] step-local-metrics - Field stats that are generated from the router rather than FTV1
  • [ ] step-with-prometheus - A copy of the step test with the Prometheus metrics exporter enabled
  • [x] step - Basic stress test that steps up the number of users over time
  • [ ] xlarge-request - Stress test with 10 MB request payload
  • [ ] xxlarge-request - Stress test with 100 MB request payload

router-perf[bot] avatar Jan 17 '25 17:01 router-perf[bot]

@jesse-apollo @chandrikas - WDYT?

lambertjosh avatar Feb 07 '25 17:02 lambertjosh

@abernix

jesse-apollo avatar Feb 07 '25 17:02 jesse-apollo

I opened a ticket with @shorgi and friends to figure out what the next best steps for this PR are.

abernix avatar Apr 17 '25 10:04 abernix

Copyedited (https://github.com/apollographql/router/pull/6552/commits/e9901facab05e47671620aa1316968a546f691ca) to use generic "licensed plan" and "licensed feature".

shorgi avatar Apr 18 '25 04:04 shorgi