router icon indicating copy to clipboard operation
router copied to clipboard

feat: Adds More Options For Liveness/Readiness Probe

Open ahiggins0 opened this issue 1 year ago • 2 comments

Makes the liveness/readiness probes a little more customizable.

Fixes #2363


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • [x] Changes are compatible[^1]
  • [ ] Documentation[^2] completed
  • [ ] Performance impact assessed and acceptable
  • Tests added and passing[^3]
    • [ ] Unit Tests
    • [ ] Integration Tests
    • [ ] Manual Tests

Exceptions

Note any exceptions here

Notes

Tested this change with a helm template and chart rendered fine:

cd helm/chart/router helm template router ./ --debug -f ./values.yaml

Defaults were retrieved from describing our router pods in k8s.

    Liveness:   http-get http://:8088/health%3Flive delay=0s timeout=1s period=10s #success=1 #failure=3
    Readiness:  http-get http://:8088/health%3Fready delay=0s timeout=1s period=10s #success=1 #failure=3

[^1]: It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. [^2]: Configuration is an important part of many changes. Where applicable please try to document configuration examples. [^3]: Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

ahiggins0 avatar Sep 17 '24 21:09 ahiggins0