router icon indicating copy to clipboard operation
router copied to clipboard

tell jemalloc to use 64-KiB pages

Open yanns opened this issue 1 year ago • 7 comments

Description here

Fixes #3382

For more detail about the issue:

  • https://github.com/jemalloc/jemalloc/issues/467

This change is similar to what other projects are doing. We've been using that internally as well.


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • [ ] Changes are compatible[^1]
  • [ ] Documentation[^2] completed
  • [ ] Performance impact assessed and acceptable
  • Tests added and passing[^3]
    • [ ] Unit Tests
    • [ ] Integration Tests
    • [ ] Manual Tests

Exceptions

Note any exceptions here

Notes

[^1]: It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. [^2]: Configuration is an important part of many changes. Where applicable please try to document configuration examples. [^3]: Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

yanns avatar Jun 28 '24 15:06 yanns

CI performance tests

  • [x] const - Basic stress test that runs with a constant number of users
  • [ ] demand-control-instrumented - A copy of the step test, but with demand control monitoring and metrics enabled
  • [ ] demand-control-uninstrumented - A copy of the step test, but with demand control monitoring enabled
  • [ ] enhanced-signature - Enhanced signature enabled
  • [ ] events - Stress test for events with a lot of users and deduplication ENABLED
  • [ ] events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • [ ] events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • [ ] events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • [ ] events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • [ ] events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • [ ] extended-reference-mode - Extended reference mode enabled
  • [ ] large-request - Stress test with a 1 MB request payload
  • [ ] no-tracing - Basic stress test, no tracing
  • [ ] reload - Reload test over a long period of time at a constant rate of users
  • [ ] step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • [ ] step-local-metrics - Field stats that are generated from the router rather than FTV1
  • [ ] step-with-prometheus - A copy of the step test with the Prometheus metrics exporter enabled
  • [x] step - Basic stress test that steps up the number of users over time
  • [ ] xlarge-request - Stress test with 10 MB request payload
  • [ ] xxlarge-request - Stress test with 100 MB request payload

router-perf[bot] avatar Jun 28 '24 15:06 router-perf[bot]

It's probably the right thing to do at this point. I really hoped that they'd fix this inside jemalloc, but ...

garypen avatar Jul 02 '24 11:07 garypen

Maybe we could use this to enforce it for the project, even locally ? cc @garypen. @SimonSapin did you already use this ?

bnjjj avatar Jul 04 '24 09:07 bnjjj

@bnjjj That's a good suggestion I think. I suppose it would only apply to people developing/testing on Linux (we don't use jemalloc on macOS/Windows). Could you try it out?

garypen avatar Jul 04 '24 10:07 garypen

@mergify copy dev

abernix avatar May 21 '25 13:05 abernix

copy dev

✅ Pull request copies have been created

mergify[bot] avatar May 21 '25 13:05 mergify[bot]

✅ Docs preview has no changes

The preview was not built because there were no changes.

Build ID: 23c1d99706cecd60a39c0293

svc-apollo-docs avatar Jun 04 '25 08:06 svc-apollo-docs