router icon indicating copy to clipboard operation
router copied to clipboard

Configurability of log attributes

Open BrynCooke opened this issue 1 year ago • 2 comments

Currently when configuring the attributes that are output onto log events we have the following:

telemetry:
  exporters:
    logging: 
      stdout:
        format: 
          json:
            display_span_list: true # Output all attributes from all spans to the root
            display_current_span: true # Output attributes from the current span

When following the otel conventions there can be a large number of span attributes, and users need the ability to specify which attributes should be output rather than the all or nothing settings we have already.

Users needs to be able to opt in to attributes so that they can be sure that only the attributes they want are output.

BrynCooke avatar Jun 26 '24 09:06 BrynCooke

The PRs that closed items 3 and 4 are linked in the description, but is also here: #5447

So to confirm, this ticket can sample a custom trace id. 3 & 4 from last ticket would help to append to custom request logs. Does 3/4 allow custom trace id format like UUID? Based on the router schema definition 3 and 4 requires hexadecimal/ decimal, open_telemetry/datadog format, or are these format specific for experimental_response_trace_id feature only?

Samjin avatar Jun 27 '24 23:06 Samjin

a1e81c42-5558-4b62-a363-a6dbcc1014dc as example trace id

Samjin avatar Jul 02 '24 15:07 Samjin

Added suggested config. We are going to tackle the uuid formatting thing separately.

BrynCooke avatar Jul 05 '24 13:07 BrynCooke