router icon indicating copy to clipboard operation
router copied to clipboard

Add connect span for connectors field

Open pubmodmatt opened this issue 1 year ago • 1 comments

  • Add a connect span for each field with a connector
  • Add unit test to check for connect span (adds dev-dependency on tracing-fluent-assertions)
  • Remove extra space at the end of connector label
  • Refactor connector test file locations

Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • [ ] Changes are compatible[^1]
  • [ ] Documentation[^2] completed
  • [ ] Performance impact assessed and acceptable
  • Tests added and passing[^3]
    • [ ] Unit Tests
    • [ ] Integration Tests
    • [ ] Manual Tests

Exceptions

Notes

[^1]: It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. [^2]: Configuration is an important part of many changes. Where applicable please try to document configuration examples. [^3]: Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

pubmodmatt avatar Jun 25 '24 02:06 pubmodmatt