router
router copied to clipboard
isolate uses of hyper 0.14 types
To prepare the migration to hyper 1.0, this PR isolates uses of hyper's types in the Router, to make sure that we do not get stuck updating it all over the code.
One of the issues with the update is that some types exported by hyper, mainly the Body, but also the http crate's Request and Response types, along with related builders, are reexported by the Router. This will potentially create issues for users of native plugins.
Goals of this PR:
- [ ] remove direct uses of hyper types, replace
hyper::Bodywith the wrapper typeRouterBodywhen possible, otherwise use the aliascrate::services::router::Body - [ ] provide helpers to replace direct usage of hyper, in the Router and native plugins
- [ ] mark
crate::services::router::Bodyas deprecated, pointing towards better way to create a router service request or response body - [ ]
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
- [ ] Changes are compatible[^1]
- [ ] Documentation[^2] completed
- [ ] Performance impact assessed and acceptable
- Tests added and passing[^3]
- [ ] Unit Tests
- [ ] Integration Tests
- [ ] Manual Tests
Exceptions
Note any exceptions here
Notes
[^1]: It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. [^2]: Configuration is an important part of many changes. Where applicable please try to document configuration examples. [^3]: Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.
@Geal, please consider creating a changeset entry in /.changesets/. These instructions describe the process and tooling.
CI performance tests
- [x] step - Basic stress test that steps up the number of users over time
- [ ] events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
- [ ] large-request - Stress test with a 1 MB request payload
- [ ] events - Stress test for events with a lot of users and deduplication ENABLED
- [ ] xxlarge-request - Stress test with 100 MB request payload
- [ ] events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
- [ ] xlarge-request - Stress test with 10 MB request payload
- [ ] step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
- [ ] events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
- [ ] no-graphos - Basic stress test, no GraphOS.
- [ ] reload - Reload test over a long period of time at a constant rate of users
- [ ] events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
- [ ] events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
- [x] const - Basic stress test that runs with a constant number of users
with https://github.com/apollographql/router/pull/5175/commits/733a3ede0caa863a8a72a13ce40acc5cb8f6f47a and https://github.com/apollographql/router/pull/5175/commits/402aa18b492e867995e7233155d0895735b85906 most of the uses of hyper::Body have disappeared. If I uncomment the #[deprecated] attribute on it, I still see 65 warnings (70 with tests), but they are mainly under services::router and router service plugins (unavoidable there).
@garypen do you see anything else to change here?
I'd like to get this merged before I get to other changes to the HTTP service and its related plugins