router icon indicating copy to clipboard operation
router copied to clipboard

Enhanced signature generation

Open BrynCooke opened this issue 1 year ago • 1 comments

Adds a new experimental configuration to support enhanced signature generation. The changes are:

Remove some hacks and quirks of the JS implementation related to properly sorting everything and using commas vs spaces Includes aliases in the signature Includes the full normalized form of input objects Fixes ROUTER-262 Replaces PR #5062

To get this over the line the tests need a little refactoring to use insta and maybe Asset to allow easy addition of new tests.


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • [ ] Changes are compatible[^1]
  • [ ] Documentation[^2] completed
  • [ ] Performance impact assessed and acceptable
  • Tests added and passing[^3]
    • [ ] Unit Tests
    • [ ] Integration Tests
    • [ ] Manual Tests

Exceptions

Note any exceptions here

Notes

[^1]: It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. [^2]: Configuration is an important part of many changes. Where applicable please try to document configuration examples. [^3]: Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

BrynCooke avatar May 13 '24 12:05 BrynCooke

CI performance tests

  • [x] step - Basic stress test that steps up the number of users over time
  • [ ] events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • [ ] large-request - Stress test with a 1 MB request payload
  • [ ] events - Stress test for events with a lot of users and deduplication ENABLED
  • [ ] xxlarge-request - Stress test with 100 MB request payload
  • [ ] events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • [ ] xlarge-request - Stress test with 10 MB request payload
  • [ ] step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • [ ] events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • [ ] no-graphos - Basic stress test, no GraphOS.
  • [ ] reload - Reload test over a long period of time at a constant rate of users
  • [ ] events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • [ ] events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • [x] const - Basic stress test that runs with a constant number of users

router-perf[bot] avatar May 13 '24 12:05 router-perf[bot]

I've addressed the PR comments but I don't have access to push to this branch/PR. I made a new branch/PR but it's based on the latest dev code so there are some unrelated changes in the PR. If this branch is synced with dev I think the PR should look a lot cleaner.

https://github.com/apollographql/router/pull/5285

bonnici avatar May 30 '24 04:05 bonnici

I just merged dev in both branches and solved conflicts, #5285 looks much smaller now

Geal avatar May 31 '24 08:05 Geal

I've merged https://github.com/apollographql/router/pull/5285 into this branch now and addressed the remaining PR comments.

bonnici avatar Jun 03 '24 03:06 bonnici