router icon indicating copy to clipboard operation
router copied to clipboard

Option to send error details to Studio in usage reporting (bonus: with option to redact message parts)

Open lennyburdette opened this issue 3 years ago • 3 comments

Is your feature request related to a problem? Please describe. It would be useful to see error messages in Studio. Right now, all we get is the path to the error and <masked>. Screen Shot 2022-10-27 at 11 28 18 AM

Describe the solution you'd like This behavior should be off by default, and users could enable it for routers running in development environments.

Ideally, they can also provide transforms for omitting errors from reporting entirely, or redacting error parts. A simple version in YAML that omits or redacts based on a regular expression would probably cover 80%, and a rhai hook would cover the last 20%.

Additional context Apollo Server has extensive functionality for enabling and customizing error reporting to Studio: https://www.apollographql.com/docs/apollo-server/data/errors/#for-apollo-studio-reporting

lennyburdette avatar Oct 27 '22 15:10 lennyburdette

A customer just pointed out that errors in traces are always included if the subgraph provides them in the inline-trace plugin. (And the AS3 default behavior was to include errors in traces). So we also want a way to toggle that behavior (and it should probably be <masked> by default?)

lennyburdette avatar Feb 07 '23 15:02 lennyburdette

A customer just pointed out that errors in traces are always included if the subgraph provides them in the inline-trace plugin. (And the AS3 default behavior was to include errors in traces). So we also want a way to toggle that behavior (and it should probably be <masked> by default?)

Note that this aspect of this larger umbrella issue is no longer true and we redact subgraph errors which are included in the inline-trace plugin unless redact: false is set.

abernix avatar Jun 05 '23 09:06 abernix

This has been coming up multiple customers. GraphOS should be able to track detailed subgraph error messages, stack traces, and extensions from subgraphs without sending those to users, and we can not get that working. Even without support of FTV1 tracing we should be able to send info to GraphOS

smyrick avatar Apr 10 '24 19:04 smyrick