router
router copied to clipboard
Published
20 hours ago •
apollographql
apollographql
API 1.0 - Service naming
Currently we have:
- Router - RouterRequest, RouterResponse
- QueryPlanning - QueryPlannerRequest, QueryPlannerResponse
- Execution - ExecutionRequest, ExecutionResponse
- Subgraph - SubgraphRequest, SubgraphResponse
In particular the RouterService seems badly named.
Maybe GraphQLService or FederatedGraphQLService?
Having RouterService deal with anything that is non graphql is maybe a mixing of concerns.
Suggestion:
- Http - http::Request, http::Response
- Graphql - GraphlRequest, GraphqlResponse
- QueryPlanning - QueryPlannerRequest, QueryPlannerResponse
- Execution - ExecutionRequest, ExecutionResponse
- Subgraph - SubgraphRequest, SubgraphResponse
Also consider structure naming:
Currently we have:
- Router - RouterRequest, RouterResponse
- QueryPlanning - QueryPlannerRequest, QueryPlannerResponse
- Execution - ExecutionRequest, ExecutionResponse
- Subgraph - SubgraphRequest, SubgraphResponse
In particular QueryPlanner request/response don't match the service name.
relates to: #1140
Is this the right issue to discuss the potential need for an "executionNode" service?
