persistgraphql icon indicating copy to clipboard operation
persistgraphql copied to clipboard

Adding ability to process js, graphql, and other arbitrary file types (e.g. .gql)

Open mergebandit opened this issue 8 years ago • 8 comments

extension property / argument now supports multiple file types.

This allows users to execute persistgraphql in environments that utilize the gql tagged template literal, .graphql files, .gql files, and any arbitrary extension that consumers have defined for graphql files.

Specifically, the persistgraphql-webpack-plugin defines a loader for .graphql|.gql files, which was my original aim to support.

Fixes #50

mergebandit avatar Oct 26 '17 19:10 mergebandit

@mergebandit: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

apollo-cla avatar Oct 26 '17 19:10 apollo-cla

@mergebandit Thanks so much for the PR! I mentioned a couple of changes above that should be pretty easy to implement. I think the concept is fine otherwise.

Poincare avatar Oct 27 '17 04:10 Poincare

@Poincare - left some responses above.

mergebandit avatar Oct 31 '17 00:10 mergebandit

@mergebandit Yup saw those - will respond to each in about 1-2 days.

Poincare avatar Oct 31 '17 05:10 Poincare

Bump.

mergebandit avatar Nov 06 '17 21:11 mergebandit

Also - I'll need to bump the minor version in my next commit (reminder to myself)

mergebandit avatar Nov 13 '17 22:11 mergebandit

@Poincare I (and others on my team) would be more than happy to assist in ongoing maintenance and feature development for this plugin.

mergebandit avatar Nov 16 '17 16:11 mergebandit

Is this ever going to be addressed or should I just maintain a fork moving forward?

mergebandit avatar Nov 29 '17 05:11 mergebandit