apollo-tooling icon indicating copy to clipboard operation
apollo-tooling copied to clipboard

Sort types when generating

Open gravyboat opened this issue 3 years ago • 1 comments

I don't know if this will be merged or considered since it seems like the repo is no longer maintained but I'd love to get this in and addressed as it's quite annoying when doing type generation to constantly run in to this. I'd prefer not to give my information to Apollo via the license agreement, so I'd be okay with this code being taken and merged by an actual contributor if that's possible. Let me know.

Types are not currently sorted when regenerating the graphql schema. This results in constantly changing types based on what was queried first leading to unnecessary merge conflicts as the type order changes. This addresses the issue by sorting the type array before it is returned.<!-- Thanks for filing a pull request on Apollo Tooling!

Please look at the following checklist to ensure that your PR can be accepted quickly: -->

TODO:

  • [x] Update CHANGELOG.md* with your change (include reference to issue & this PR)
  • [ ] Make sure all of the significant new logic is covered by tests
    • Did not do this as it seems unnecessary based on the existing tests
  • [x] Rebase your changes on master so that they can be merged easily
  • [ ] Make sure all tests and linter rules pass *Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.

gravyboat avatar Feb 24 '22 19:02 gravyboat

@gravyboat: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

apollo-cla avatar Feb 24 '22 19:02 apollo-cla

It's been a year with no updates from the maintainers, closing.

gravyboat avatar Jun 21 '23 18:06 gravyboat