apollo-tooling icon indicating copy to clipboard operation
apollo-tooling copied to clipboard

Published 20 hours ago • verified publisher icon apollographql

feat(apollo-codegen-typescript): Support scalar JSDoc annotations

Open nalchevanidze opened this issue 3 years ago • 2 comments
trafficstars

fixes #2544

TODO:

  • [ ] Update CHANGELOG.md* with your change (include reference to issue & this PR)
  • [ ] Make sure all of the significant new logic is covered by tests
  • [ ] Rebase your changes on master so that they can be merged easily
  • [ ] Make sure all tests and linter rules pass

*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.

nalchevanidze avatar Jan 14 '22 15:01 nalchevanidze

@nalchevanidze: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

apollo-cla avatar Jan 14 '22 15:01 apollo-cla

There are some cases and tests that need to be covered, and that will be addressed. But the question is if you like the idea too? We can also implement a more general approach with a plugin interface where I could put this code in the plugin and combine it with the base implementation?

nalchevanidze avatar Jan 14 '22 16:01 nalchevanidze