apollo-tooling icon indicating copy to clipboard operation
apollo-tooling copied to clipboard

fix(apollo): codegen fails on graphql error

Open royra opened this issue 5 years ago • 5 comments

The client:codegen command was exiting with code 0 even if the queries had errors. Fixes #1980

TODO:

  • [X] Update CHANGELOG.md* with your change (include reference to issue & this PR)
  • [X] Make sure all of the significant new logic is covered by tests
  • [X] Rebase your changes on master so that they can be merged easily
  • [X] Make sure all tests and linter rules pass

*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.

royra avatar Sep 07 '20 15:09 royra

@royra: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

apollo-cla avatar Sep 07 '20 15:09 apollo-cla

We also keeping running into this issue, would be great to get it fixed! Anything I can do to help @royra?

russellporter avatar Nov 25 '20 16:11 russellporter

I signed the CLA on the same day, not sure why this wasn't reviewed yet.

royra avatar Nov 25 '20 20:11 royra

I contacted Apollo support through their website to request a code review for this. Hopefully it helps 🤞

russellporter avatar Nov 28 '20 15:11 russellporter

really hope this gets looked at soon; our own CI is incomplete without this. As a workaround I plan to just use grep and a bash script to check for keywords such as failed in the command output and throw a non-zero exit code, which definitely isn't ideal.

Ry-DS avatar Nov 12 '21 03:11 Ry-DS