apollo-server icon indicating copy to clipboard operation
apollo-server copied to clipboard

Include the compatible graphql version to incremental delivery docs

Open thomaswelton opened this issue 1 year ago • 3 comments
trafficstars

Updated the documentation on incremental delivery to include the specific prerelease version of graphQL that Apollo Server is compatible with for incremental delivery.

The current docs state "As of September 2022...", but a new pre release version was made available in 2023 https://github.com/graphql/graphql-js/releases/tag/v17.0.0-alpha.3 and this appears to contain a breaking change in the incremental payload delivery.

thomaswelton avatar Feb 13 '24 20:02 thomaswelton

@thomaswelton: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

apollo-cla avatar Feb 13 '24 20:02 apollo-cla

Deploy request for apollo-server-docs pending review.

Visit the deploys page to approve it

Name Link
Latest commit 37957d9e23c7676ba0749e2c72d37c5e49e479a5

netlify[bot] avatar Feb 13 '24 20:02 netlify[bot]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

codesandbox-ci[bot] avatar Feb 13 '24 20:02 codesandbox-ci[bot]

@thomaswelton did you confirm that alpha.2 is working? We currently test against a specific canary, maybe we should update those references to alpha.2 as well. i.e. our tests use graphql@17.0.0-alpha.1.canary.pr.3361.04ab27334641e170ce0e05bc927b972991953882

trevor-scheer avatar Mar 05 '24 18:03 trevor-scheer

For our test cases Alpha 2 works, we're now using defer in production

thomaswelton avatar Mar 05 '24 18:03 thomaswelton

@thomaswelton would you mind updating the couple references in the repo to alpha.2? I can as well if you don't mind me pushing to your branch.

trevor-scheer avatar Mar 05 '24 19:03 trevor-scheer

@trevor-scheer Sure done

thomaswelton avatar Mar 05 '24 19:03 thomaswelton