apollo-link icon indicating copy to clipboard operation
apollo-link copied to clipboard

Update apollo-link example to correctly console.log the person's name

Open program247365 opened this issue 5 years ago • 2 comments

The example currently logged undefined. Perhaps the API it fetched from changed recently. This update makes it correctly log Luke Skywalker.

TODO:

  • [x] Make sure all of new logic is covered by tests and passes linting
  • [x] Update CHANGELOG.md with your change

program247365 avatar Jan 06 '20 17:01 program247365

@program247365: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

apollo-cla avatar Jan 06 '20 17:01 apollo-cla

Codecov Report

Merging #1233 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1233   +/-   ##
======================================
  Coverage    95.6%   95.6%           
======================================
  Files          22      22           
  Lines        1116    1116           
  Branches      174     174           
======================================
  Hits         1067    1067           
  Misses         44      44           
  Partials        5       5

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d56fce6...77aede3. Read the comment docs.

codecov-io avatar Jan 06 '20 17:01 codecov-io