apollo-link icon indicating copy to clipboard operation
apollo-link copied to clipboard

Adds missing peer dependency

Open arcanis opened this issue 6 years ago β€’ 3 comments

apollo-link-error has a transitive peer dependency on graphql through apollo-link, and must be marked as such. Cf my article why implicit transitive peer dependencies are bad πŸ™‚

As long as you're here, can you please give a look to the following related PRs? πŸ˜ƒ

arcanis avatar Nov 11 '19 15:11 arcanis

@arcanis: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

apollo-cla avatar Nov 11 '19 15:11 apollo-cla

Codecov Report

Merging #1196 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1196   +/-   ##
======================================
  Coverage    95.6%   95.6%           
======================================
  Files          22      22           
  Lines        1116    1116           
  Branches      174     162   -12     
======================================
  Hits         1067    1067           
  Misses         44      44           
  Partials        5       5

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update cdef549...60e98d1. Read the comment docs.

codecov-io avatar Nov 11 '19 15:11 codecov-io

And there are few more; apollo-link-context also doesn't have peerDeps.

I can't use apollo with yarn 2 because of this. Any plan to update?

cometkim avatar Apr 01 '20 14:04 cometkim