apollo-client icon indicating copy to clipboard operation
apollo-client copied to clipboard

Published 20 hours ago • verified publisher icon apollographql

Pass mutation input and context to handlers

Open LeeKevin opened this issue 5 years ago • 3 comments
trafficstars

Pass input and context from mutation function to onCompleted/onError handlers.

Checklist:

  • [ ] If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • [ ] Make sure all of the significant new logic is covered by tests

LeeKevin avatar May 04 '20 23:05 LeeKevin

@LeeKevin: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

apollo-cla avatar May 04 '20 23:05 apollo-cla

This is a small but hugely beneficial change for me. @LeeKevin any chance you're still working on this?

drummerjolev avatar Mar 17 '21 09:03 drummerjolev

This is a great addition. If @LeeKevin or anyone else is interested in rebasing this, and adding a test or two, we'll get this merged. Thanks!

hwillson avatar Aug 10 '22 23:08 hwillson

Went ahead and implemented this change in https://github.com/apollographql/apollo-client/pull/10052, thanks y'all!

All the best, Emmanuel, Intern:-)

MrDoomBringer avatar Sep 02 '22 01:09 MrDoomBringer