apollo-client icon indicating copy to clipboard operation
apollo-client copied to clipboard

Make useRenderGuard and profile work with React 19

Open Tobbe opened this issue 1 year ago • 3 comments
trafficstars

React 19 has changed the names of some internal variables. This PR updates the @apollo/client React integration to also support these new names.

The React changes were introduced here https://github.com/facebook/react/commit/f6131653570bbbf62d642ba9343b9cd0ab1ae97c

Also updating the version of @testing-library/react to a version that supports React 19. Support was introduced in https://github.com/testing-library/react-testing-library/releases/tag/v14.3.0

Tobbe avatar Apr 20 '24 09:04 Tobbe

@Tobbe: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

apollo-cla avatar Apr 20 '24 09:04 apollo-cla

Deploy request for apollo-client-docs pending review.

Visit the deploys page to approve it

Name Link
Latest commit 951ff42c8cedcb6edcffe692873238fcc594798c

netlify[bot] avatar Apr 20 '24 09:04 netlify[bot]

🦋 Changeset detected

Latest commit: 951ff42c8cedcb6edcffe692873238fcc594798c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@apollo/client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Apr 20 '24 09:04 changeset-bot[bot]

Thanks for the PR!

We found a way to do this without accessing React internals at all over in #11888, which is probably less flaky in the long run, so I'm going to close this :)

phryneas avatar Jun 25 '24 09:06 phryneas