apollo-client-devtools icon indicating copy to clipboard operation
apollo-client-devtools copied to clipboard

Published 20 hours ago • verified publisher icon apollographql

fix: cache data empty in queries tab

Open mohit23x opened this issue 3 years ago • 1 comments

This PR fixes the cache data empty issue in the Queries tab, fixes #816

Screenshots

BEFORE AFTER
image image

mohit23x avatar Sep 20 '22 13:09 mohit23x

@mohit23x: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

apollo-cla avatar Sep 20 '22 13:09 apollo-cla

Hey @Jephuff @mayakoneval @alex-wilmer @cheapsteak can you folks check this PR once. What i found was after apollo version 3.4.17 the diff variable is not present in the observableQuery.queryInfo object.

mohit23x avatar Oct 03 '22 14:10 mohit23x

Would love to get this merged

pbassut avatar Oct 09 '22 07:10 pbassut

Thanks a ton for this PR!

I went ahead and updated your branch to use the getDiff() function, which should be cleaner and more stable than accessing lastDiff directly. After tests pass I'll go ahead and merge.

All the best, Emmanuel :-)

MrDoomBringer avatar Nov 29 '22 18:11 MrDoomBringer