apollo-client-devtools icon indicating copy to clipboard operation
apollo-client-devtools copied to clipboard

fix: do not break Import Maps

Open hronro opened this issue 4 years ago • 1 comments

Fix #464

hronro avatar Oct 18 '21 08:10 hronro

@hronro: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

apollo-cla avatar Oct 18 '21 08:10 apollo-cla

Hey @hronro, thanks a ton for the PR!

I went ahead and added a commit that waits for the DOMContentLoaded event before injecting the script, just to be sure we have access to the importmap script if it's available. Tested on https://generator.jspm.io/, the AC fullstack tutorial (w/ apollo/[email protected]), and the DevTools example app (apollo/[email protected])

Will get this merged shortly pending a quick once-over

All the best, Emmanuel :-)

MrDoomBringer avatar Nov 01 '22 14:11 MrDoomBringer