apollo-cache-persist icon indicating copy to clipboard operation
apollo-cache-persist copied to clipboard

Add a generic parameter so TS users can use `serialize: false`

Open pzuraq opened this issue 3 years ago • 2 comments
trafficstars

Fixes #465, this has been the pattern I've generally seen for passing down generics like this. It is an unfortunate amount of boilerplate, but the type-safety you get with it is usually worth it (e.g. being able to constrain the other values of the config, in this case).

pzuraq avatar Sep 25 '22 15:09 pzuraq

@pzuraq: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

apollo-cla avatar Sep 25 '22 15:09 apollo-cla

Do we think we can merge this soon?

I am in process of making another Pull Request to work with latest MMKVStorageWrappers and would like to merge this first

kdsbatra avatar Dec 15 '22 17:12 kdsbatra