currencylayer-API icon indicating copy to clipboard operation
currencylayer-API copied to clipboard

Quote: "USDUSD" is missing

Open danielmarschall opened this issue 3 years ago • 5 comments

Hello,

I noticed that in CurrencyLayer, the quote entry "USDUSD" is missing. It should have the value 1. My OpenSource software relied on this value and due to the change at CurrencyLayers, the apps don't work anymore. Can you please re-add it again? Thank you.

Best regards, Daniel Marschall

PS: I tried to contact via https://currencylayer.com/contact but I get the error message "Unable to create support ticket.".

danielmarschall avatar Aug 06 '22 18:08 danielmarschall

All conversions where source and destination are the same have been removed as well. It could be due to the issue mentioned above https://github.com/apilayer/currencylayer-API/issues/14 and https://github.com/apilayer/currencylayer-API/issues/15

richardbiddle avatar Aug 08 '22 01:08 richardbiddle

Of course, the entry "USDUSD" must always be 1 . The other bug reports reported that the value is not equal 1, which is clearly wrong. It is unfortunate for me that the bugfix was to remove "USDUSD" instead of hard-coding it to value 1. Backwards compatibility should be a number 1 goal for any API developer.

But I have added a workaround to my library. However, I hope there aren't too much of my users affected (my OpenSource middleware is 900 times downloaded. I have no idea who is actively using it, though).

Side note: I want to explain why the lack of "USDUSD" broke my code. I had to get a list of all currencies, and to get it, I simply listed all quotes and extracted the last 3 bytes of each entry. With "USDUSD" missing, I didn't got USD as currency.

danielmarschall avatar Aug 08 '22 22:08 danielmarschall

This random change just made my day not fun too!

NikolaosWakem avatar Aug 11 '22 14:08 NikolaosWakem

This is a breaking change to the API contract. The hardcoding of 1 should be done on the API side to maintain backwards compatibility.

ikottman avatar Aug 11 '22 16:08 ikottman

Please put USDUSD back with a constant value of 1. This a breaking change which screwed up my day and a lot of my colleagues.

cyrnetix avatar Aug 15 '22 09:08 cyrnetix