up icon indicating copy to clipboard operation
up copied to clipboard

up start -s production doesn't run build hooks.

Open chanlito opened this issue 7 years ago • 4 comments

Is this intentional?

chanlito avatar Jun 11 '18 07:06 chanlito

Currently it is, but that might change. It's a tough call, it sort of depends on the situation so maybe there needs to be an opt-in. Always great to hear more use-cases, let me know what you think

tj avatar Jun 11 '18 18:06 tj

I don't really have a problem with it. Just save some typings.

chanlito avatar Jun 13 '18 10:06 chanlito

My main worry is running something in the build hook that is meant more for a deploy in CI etc.

In the case of Go for example it builds a Linux binary not one for Mac/Windows so it wouldn't work by default, might have to map commands per-environment or something like that.

tj avatar Jun 13 '18 17:06 tj

I would give this a +1. up deploy builds the project (in case of java compiles the source code), before it uploads to Lambda. up start is just a deploy to your localhost, so it should have the same behaviour as up deploy

aronneagu avatar Jun 20 '18 20:06 aronneagu