fflib-apex-common

fflib-apex-common copied to clipboard

bugfix for Issue 221

7

fix for https://github.com/apex-enterprise-patterns/fflib-apex-common/issues/221 from @dsurfleet - - - This change is [](https://reviewable.io/reviews/apex-enterprise-patterns/fflib-apex-common/449)

jprichter

This change is [](https://reviewable.io/reviews/apex-enterprise-patterns/fflib-apex-common/441)

Javwadazeem

fflib_SObjectSelectorTest failure with Lookup relationship and Person Type Accounts

5

**Describe the bug** The test `toSOQL_When_SystemModeAndChildRelationship_Expect_WellFormedSOQL()` relies on `fflib_QueryFactory.getChildRelationship(SObjectType)`, which can get an unexpected relationship when Person Type Accounts are enabled. `Opportunities` is not guaranteed to be the first child...

CSigelmann

fflib_SObjectSelectorTest Error: 'Assertion Failed: Expected: 12345.67, Actual: 9117.25'

13

**Describe the bug** when I run the tests in 'fflib_SObjectSelectorTest Class' I get the following error. System.AssertException: Assertion Failed: Expected: 12345.67, Actual: 9117.25 CODE LINE: system.assertEquals(12345.67,result[0].AnnualRevenue); I think this has...

adayIvey

Type casting SObjectField to 'String' throws errors for non-string field types

3

**Describe the bug** In the `fflib_SObjects` class, all these methods: - getStringFieldValues - getRecordsWithBlankFieldValues - getRecordsWithAllBlankFieldValues - getRecordsWithNotBlankFieldValues - getRecordsWithAllNotBlankFieldValues are type casting SObjectFields to String. This is fine for...

cnwork

Fixes #495 Replace the manual type casting of field values into String with `String.valueOf()`. - - - This change is [](https://reviewable.io/reviews/apex-enterprise-patterns/fflib-apex-common/496)

cnwork

The method `private fflib_QueryFactory setSubselectQuery(Schema.ChildRelationship relationship, Boolean assertIsAccessible)` has a check that prevents a subselect being added to a subselect - e.g. ``` if (this.relationship != null){ throw new InvalidSubqueryRelationshipException('Invalid...

phil-apexology

Fixes #487 - uses the explicit relationship name rather than the SObject inference (deprecated) method for resolving the relationship name

1

This change is [](https://reviewable.io/reviews/apex-enterprise-patterns/fflib-apex-common/493)

daveespo