fflib-apex-common icon indicating copy to clipboard operation
fflib-apex-common copied to clipboard

Published 20 hours ago • verified publisher icon apex-enterprise-patterns

fflib-apex-common | mateuszzw | add addCondition() method to QueryFactory

Open mateuszzw opened this issue 3 years ago • 3 comments
trafficstars

Hi @ImJohnMDaniel Since our team had a need for a method that adds to already existing conditions and not just setting them, here's my pull request to add that functionality. Feel free to comment, I'm really curious what you think :)

This change is Reviewable

mateuszzw avatar Aug 16 '22 18:08 mateuszzw

Hi @ImJohnMDaniel it's open for a long time already. I know you're probably extra busy, but is there any chance for you to take a look at it? Thanks!

mateuszzw avatar Sep 20 '22 12:09 mateuszzw

@ImJohnMDaniel @stohn777 This looks interesting. What are you're thoughts on this being included?

chazwatkins avatar Dec 02 '22 03:12 chazwatkins

This change is under review but we are currently focusing on efforts to incorporate USER_MODE. Once we get this stable, then we will focus on other efforts like this.

ImJohnMDaniel avatar Dec 03 '22 20:12 ImJohnMDaniel