kubeblocks
kubeblocks copied to clipboard
fix: don't ignore not found error in its controller
When kb enables IN_PLACE_POD_VERTICAL_SCALING feature gate, but k8s does not, a vscale operation may fail in its because kube-apiserver does not have the "resize" subresource. ITS controller should error emit a warning event like:
Warning FailedReconcile 15m (x12 over 15m) instance-set-controller reconcile failed: the server could not find the requested resource
But instead, its controller silently ignores this error and makes the reconcilation successful.
Auto Cherry-pick Instructions
Usage:
- /nopick: Not auto cherry-pick when PR merged.
- /pick: release-x.x [release-x.x]: Auto cherry-pick to the specified branch when PR merged.
Example:
- /nopick
- /pick release-1.0
Codecov Report
:x: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 50.74%. Comparing base (0b9a9e2) to head (7cc2685).
:warning: Report is 1 commits behind head on main.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| pkg/controller/kubebuilderx/plan_builder.go | 0.00% | 8 Missing and 3 partials :warning: |
| pkg/controller/kubebuilderx/controller.go | 0.00% | 1 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #9823 +/- ##
==========================================
- Coverage 50.86% 50.74% -0.13%
==========================================
Files 542 542
Lines 58771 58770 -1
==========================================
- Hits 29895 29823 -72
- Misses 25927 25997 +70
- Partials 2949 2950 +1
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 50.74% <0.00%> (-0.13%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
The review comments above are addressed. @leon-inf PTAL