kubeblocks icon indicating copy to clipboard operation
kubeblocks copied to clipboard

feat: support validate policy of opsrequest

Open ian-hui opened this issue 1 year ago • 1 comments

solve #8231

ian-hui avatar Sep 29 '24 10:09 ian-hui

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Sep 29 '24 10:09 CLAassistant

fix the conflicts and make test error

wangyelei avatar Nov 05 '24 08:11 wangyelei

fix the conflicts and make test error

sorry that i forgot to push newest code. I have already push the newest version. plz check.

ian-hui avatar Nov 05 '24 12:11 ian-hui

@ian-hui image

wangyelei avatar Nov 06 '24 01:11 wangyelei

Codecov Report

Attention: Patch coverage is 61.45833% with 37 lines in your changes missing coverage. Please review.

Project coverage is 61.22%. Comparing base (0d4a0b5) to head (9ea1a07).

Files with missing lines Patch % Lines
pkg/operations/horizontal_scaling.go 67.04% 19 Missing and 10 partials :warning:
apis/operations/v1alpha1/opsrequest_validation.go 0.00% 8 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8232      +/-   ##
==========================================
+ Coverage   61.12%   61.22%   +0.10%     
==========================================
  Files         351      357       +6     
  Lines       41743    42192     +449     
==========================================
+ Hits        25517    25834     +317     
- Misses      13927    14010      +83     
- Partials     2299     2348      +49     
Flag Coverage Δ
unittests 61.22% <61.45%> (+0.10%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Nov 10 '24 08:11 codecov[bot]

do not force push; retain commit history.

wangyelei avatar Nov 11 '24 03:11 wangyelei

do not force push; retain commit history.

all right. I'll make corrections

ian-hui avatar Nov 11 '24 03:11 ian-hui

/approved

wangyelei avatar Nov 21 '24 02:11 wangyelei