yunikorn-web icon indicating copy to clipboard operation
yunikorn-web copied to clipboard

[YUNIKORN-2349] Change the orientation of the queue

Open doupache opened this issue 1 year ago • 8 comments

What is this PR for?

https://github.com/user-attachments/assets/0caa15fd-9089-4abf-8d7f-af7cb8cfede1

What type of PR is it?

  • [x] - Feature

What is the Jira issue?

YUNIKORN-2349

doupache avatar Sep 06 '24 13:09 doupache

This PR builds upon the changes introduced in #189 and should be reviewed or merged after #189 has been completed.

doupache avatar Sep 06 '24 13:09 doupache

@doupache please rebase on master, #189 has been merged.

craigcondit avatar Sep 06 '24 14:09 craigcondit

This pr also contain the commit in #197. Once we merge it , i will rebase this one

doupache avatar Sep 12 '24 16:09 doupache

gentle ping @doupache , could you help fix the conflicts ? Thanks

brandboat avatar Sep 18 '24 04:09 brandboat

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 38.77%. Comparing base (20f66e5) to head (480d22f).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #202   +/-   ##
=======================================
  Coverage   38.77%   38.77%           
=======================================
  Files           2        2           
  Lines          49       49           
=======================================
  Hits           19       19           
  Misses         27       27           
  Partials        3        3           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Sep 18 '24 04:09 codecov-commenter

Thank you @brandboat and @ryankert01 for the review. I've resolved the conflict in the master branch, addressed the incorrect resource format, and added test cases to ensure proper handling of the incorrect resource format.

doupache avatar Sep 19 '24 08:09 doupache

@doupache Can you rebase? Also, would it be possible to remove / reduce the animation on resize? It's quite slow.

craigcondit avatar Sep 24 '24 22:09 craigcondit

@craigcondit I've merged the master branch and improved the resize animation speed. Could you please review these changes? Thank you for your time.

doupache avatar Oct 11 '24 14:10 doupache