yunikorn-web
yunikorn-web copied to clipboard
[YUNIKORN-2354] Detailed queue info
What is this PR for?
https://github.com/user-attachments/assets/11365d21-50bc-4003-938c-6020a136d8e8
What type of PR is it?
- [ ] - Feature
What is the Jira issue?
Thanks @chenyulin0719 for reviewing!
I have added the formatter tests and also removed the unnecessary console logs. Also added the missing guarantee block.
I duplicated the ResourceColumnFormatter, creating one version for the queue page and another for the application page. I believe this duplication is acceptable and makes the code more readable.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 38.77%. Comparing base (
602ca5e) to head (d43e515). Report is 4 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #197 +/- ##
=======================================
Coverage 38.77% 38.77%
=======================================
Files 2 2
Lines 49 49
=======================================
Hits 19 19
Misses 27 27
Partials 3 3
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Can we tighten up the display a little? There's a ton of whitespace, and the additional colors don't really add much but take up yet more space. Queue name and status could be combined into one line, with the labels removed. For example:
root.a.a1 [Active]
Better yet, since active is the default, leave off the status unless it is inactive:
root.a.a1
vs.
root.a.a1 [Inactive]
We can save a lot of space by removing the color and left-justifying all the resource types. For example, instead of:
Allocated:
Memory: 95.37 MB
CPU: 80m
We could do something like:
Allocated:
### narrow gap here ###
Memory: 95.37 MB
CPU: 80m
Ideally, vertical scrolling would not be necessary in the majority of cases.
Inactive queue
Active queue
@craigcondit @chenyulin0719 I have made layout tighter and add new queue data to json.db.
PTLA