tvm icon indicating copy to clipboard operation
tvm copied to clipboard

Published 20 hours ago • verified publisher icon apache

[CODEGEN] Vector-Codegen support for llvm-pure-intrin

Open rutkoor opened this issue 1 year ago • 4 comments

This PR introduces vector codegen support for llvm_pure_intrin builtin.

rutkoor avatar May 10 '24 10:05 rutkoor

@tvm-bot rerun

rutkoor avatar May 11 '24 06:05 rutkoor

cc: @tqchen @Lunderberg

rutkoor avatar May 14 '24 06:05 rutkoor

cc: @cbalint13 @ekalda

rutkoor avatar May 16 '24 13:05 rutkoor

@rutkoor Implementation LGTM (I did't go after the functionality).

cbalint13 avatar May 16 '24 14:05 cbalint13

@rutkoor Implementation LGTM (I did't go after the functionality).

Hi @cbalint13, thank you for your quick reply. And apologize for not replying back sooner.

I have added a testcase inside test_tvmscript_printer_tir.py and also explained what I am doing in the description of this PR. Please let me know if you want me to add more details.

Thanks.

rutkoor avatar Jun 03 '24 09:06 rutkoor

@rutkoor Implementation LGTM (I did't go after the functionality).

Hi @cbalint13, thank you for your quick reply. And apologize for not replying back sooner.

I have added a testcase inside test_tvmscript_printer_tir.py and also explained what I am doing in the description of this PR. Please let me know if you want me to add more details.

Thank you very much @rutkoor !

  • I had this issue https://github.com/apache/tvm/pull/15953 before, it is a good idea for such IR "expanders" to have a minimal "pretty print" test case, hence my request. Appologise to not giving more reference.

Thanks.

cbalint13 avatar Jun 03 '24 09:06 cbalint13

@tvm-bot rerun

rutkoor avatar Jun 03 '24 18:06 rutkoor