tvm icon indicating copy to clipboard operation
tvm copied to clipboard

Change relay syntax & parser to make it accept BYODT

Open jhlee525 opened this issue 3 years ago • 2 comments
trafficstars

Continuation of https://github.com/apache/tvm/pull/10008

I was struggling to parse some relay graphs with custom data type(BYODT), generating parsing error.

I found the issue and above PR, tried to test it. All work nicely with this patch.

The only problem is that it is not being merged because of some CI problem.

Above PR staled 3~4 month, so I decided to complete it. I just merged the latest code and checked that all lint stages are passing(tests/scripts/task_lint.sh). Currently no code is added or removed compare to above PR. If the original PR can be merged, than it can be deleted.

jhlee525 avatar Aug 01 '22 10:08 jhlee525

Apologies for dropping the previous PR. Got lost in my GitHub notifications. Let me know if you need help.

gussmith23 avatar Aug 02 '22 14:08 gussmith23

@leandron All right I'll change it to "Change relay syntax & parser to make it accept BYODT"

@gussmith23 Never mind, Everything is now ok and ready-to-merge. thank you for great PR!

jhlee525 avatar Aug 03 '22 05:08 jhlee525

Is there any progress going on?

rebel-jhlee avatar Aug 24 '22 06:08 rebel-jhlee

@leandron

gussmith23 avatar Aug 24 '22 15:08 gussmith23

@leandron could you tell me it can be merged or not?

Our group always patching this branch to the state-of-the-art TVM code, to parse the relay with custom type

rebel-jhlee avatar Nov 29 '22 09:11 rebel-jhlee