tvm
tvm copied to clipboard
[TFLite][CI] Update TensorFlow dependency to 2.9.1
This updates the TF version to be used in TVM CI to 2.9.1, which brings improvements so that more platforms are supported by official packages. This PR updates the Docker images scripting to install TF and TFLite and some CMake changes required when updating from TF 2.6.x to 2.9.x.
Adding it here as a draft until we get #12130 merged.
cc @areusch @Mousius @driazati @NicolaLancellotti for reviews
@leandron when investigating the Python deps I also came across this bug. We currently build a tflite library from the tensorflow source, and in TF 2.7 the build system was switched to CMake I believe. I haven't yet had time to solve this, but I'll let you know if I do.
@leandron when investigating the Python deps I also came across this bug. We currently build a tflite library from the tensorflow source, and in TF 2.7 the build system was switched to CMake I believe. I haven't yet had time to solve this, but I'll let you know if I do.
This is solved in this PR. The only issue is that the CI is testing with the old images. I'll generate a new set from ci-docker-staging and re-run the tests. it should be fine.
hm, was that https://ci.tlcpack.ai/blue/organizations/jenkins/docker-images-ci%2Fdocker-image-run-tests/detail/docker-image-run-tests/171/pipeline?
Yes. However it still requires the Docker images to have the updated TF for the whole CI.
I generated a new set, and will make a new CI staging run with the new images. Then it should be fine.
ah ok cool--lmk when i can take a look at them
@areusch just to update here as we're discussing, once this is merged, the PR that updates the Docker images, will need to update task_config_build_cpu.sh from:
echo set\(USE_TFLITE ON\) >> config.cmake
to:
echo set\(USE_TFLITE /opt/tflite\) >> config.cmake
This way we keep the default source based installation in the new format introduced here.
If I happen to do the update myself, I'll do that update above, but it will be evident if this is not there, the build will fail at Docker image testing time.
@mbrookhart could you have a look?
lgtm once comments are addressed
Thanks @driazati
@tvm-bot rerun
@tvm-bot rerun
Looks good to me, just wanted to mention that this might break microTVM testing on hardware since RVM uses a different tensorflow version. If it does we need a follow up PR. https://github.com/apache/tvm/blob/2622ac9e638b259cae017813ad93937c0ff8a2f9/apps/microtvm/pyproject.toml#L107
Looks good to me, just wanted to mention that this might break microTVM testing on hardware since RVM uses a different tensorflow version. If it does we need a follow up PR.
https://github.com/apache/tvm/blob/2622ac9e638b259cae017813ad93937c0ff8a2f9/apps/microtvm/pyproject.toml#L107
Did this change recently? I’ve run many test rounds and haven’t seen any breakage in microtvm
thanks @leandron !!
@leandron I don't think it changed recently, it should be fine