tvm icon indicating copy to clipboard operation
tvm copied to clipboard

[Pylint][microTVM] Applying Pylint rules to unittest folder

Open alanmacd opened this issue 3 years ago • 0 comments
trafficstars

Apply Pylint to the following files for issue #11414

  • tests/python/unittest/test_crt.py
  • tests/python/unittest/test_micro_model_library_format.py
  • tests/python/unittest/test_micro_project_api.py
  • tests/python/unittest/test_micro_transport.py
  • tests/python/unittest/test_node_reflection.py
  • tests/python/unittest/test_runtime_container.py
  • tests/python/unittest/test_runtime_error.py
  • tests/python/unittest/test_runtime_extension.py
  • tests/python/unittest/test_runtime_graph.py
  • tests/python/unittest/test_runtime_graph_cuda_graph.py
  • tests/python/unittest/test_runtime_graph_debug.py
  • tests/python/unittest/test_runtime_measure.py
  • tests/python/unittest/test_runtime_module_based_interface.py
  • tests/python/unittest/test_runtime_module_export.py
  • tests/python/unittest/test_runtime_module_load.py
  • tests/python/unittest/test_runtime_profiling.py
  • tests/python/unittest/test_runtime_rpc.py
  • tests/python/unittest/test_runtime_trace.py
  • tests/python/unittest/test_runtime_vm_profiler.py

Notes:

  • retained some variable names when it would either make code less readable or there were confusing redundant names that need deeper level of inspection or refactoring
  • some tvm.testing functions remain problematic
  • whitelisted variable names seem arbitrary, e.g. x & y are allowed but not z?
  • some of these files require much more effort than anticipated, (apologies for the monster-PR), I wonder if we should scan them all and rank from least to most issues to maximize efforts

@areusch @Mousius

cc @gromero @mehrdadh

alanmacd avatar Jul 12 '22 00:07 alanmacd