Fix command line input process issue.

[Liliyaw]

trafficstars

I think previously by " if [ "$#" -lt 1 -o "$1" == "--help" -o "$1" == "-h" ]; then xxx" we are trying to realize when the user input non-para, we will show help_info too? So if use previous one, it may shows unbound variable $1, may not what we hope to do.

Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.

[grant-arm]

@Mousius @ashutosh-arm for visibility.

[ashutosh-arm]

While the new syntax looks better, tbh, I don't fully understand the difference between the two. Cursory googling shows that -o / -a <OPTIONNAME> are going to be obsolete in standard, but couldn't find authentic source for it. Maybe @leandron @Mousius know more about it.

[Liliyaw]

While the new syntax looks better, tbh, I don't fully understand the difference between the two. Cursory googling shows that -o / -a are going to be obsolete in standard, but couldn't find authentic source for it. Maybe @leandron @Mousius know more about it.

Hi IMO, the difference between -o and || is that, command1 -o command2, the two commands will operate at the same time to judge the result. But for command1 || command 2, command 2 only operate when command 1 is not right. So in this use case, I guess previous you hope when CLI parameter <1( means you will not input any parameter), you will see the show_usage() information too right? But in the code above, if a user don't input any parameter, it will means $1 will not exists and then it will report an unbound variable error.

here, in this script, it's used for docker file and you can find in that file, it specify a parameter, which means $1 will never appear not existing status. The grammar doesn't report have issue but if you only use the script itself, you can find that if you don't specify any CLI para, it will not print show_usage() information. Instead with an error.

[Liliyaw]

Hi. I think both syntaxes are used and equivalent. Can you show the error message you're seeing? I tried both on my terminal and they seem to work the same way, and I'm not seeing any unbound variable error.

I tried it on MacOS and Ubuntu 20.

Have you tried run it like this? don't pass an path para to install script. IMO, the first command if "$#" -lt 1 means that when you don't pass any para to the script, it will print the show_usage() information automatically.

[gromero]

@tvm-bot rerun

[gromero]

@tvm-bot rerun