tvm icon indicating copy to clipboard operation
tvm copied to clipboard

[Relay] Support dcnv2(mask) for pytorch in tvm

Open Fvoiretryzig opened this issue 3 years ago • 5 comments

Add dcnV2 support according to this repository

Fvoiretryzig avatar Mar 24 '22 08:03 Fvoiretryzig

I have a question there, TorchVision has also implemented a version of DCNv2: https://github.com/pytorch/vision/blob/main/torchvision/csrc/ops/deform_conv2d.h , it should support exporting to torchscript. Could we also test this version?

zhiqwang avatar Mar 24 '22 14:03 zhiqwang

I'm aware that our deform covn2d support lacks mask support. If that is what this PR is about, this is great!

Please clean up your change (I see unrelated removal of existing code)

masahi avatar Mar 24 '22 21:03 masahi

I have a question there, TorchVision has also implemented a version of DCNv2: https://github.com/pytorch/vision/blob/main/torchvision/csrc/ops/deform_conv2d.h , it should support exporting to torchscript. Could we also test this version?

I wrote this operator support for compiling CenterTrack Model in tvm. It uses dcnv2 from this repository. This implementation doesn't support dcnv2 in torchvision, but it can modify the tvm pytorch frontend part to support. Does this need to change to support torchvision? @zhiqwang

Fvoiretryzig avatar Mar 25 '22 02:03 Fvoiretryzig

I'm aware that our deform covn2d support lacks mask support. If that is what this PR is about, this is great!

Please clean up your change (I see unrelated removal of existing code)

I have updated this repository. @masahi @tqchen

Fvoiretryzig avatar Mar 25 '22 03:03 Fvoiretryzig

can this pr merged? @Fvoiretryzig @masahi @tqchen

JiaqingFu avatar Feb 07 '24 02:02 JiaqingFu