thrift icon indicating copy to clipboard operation
thrift copied to clipboard

Published 20 hours ago • verified publisher icon apache

remove dependency on Six

Open a-detiste opened this issue 1 year ago • 5 comments
trafficstars

https://wiki.debian.org/Python3-six-removal

a-detiste avatar Aug 28 '24 12:08 a-detiste

There is an open ticket (https://issues.apache.org/jira/browse/THRIFT-5537) and open PRs to drop Python 2 support, which is not done yet.

I don't think we can remove the dependency of six without removing python 2 support.

fishy avatar Aug 28 '24 15:08 fishy

Unfortunately #2588 seems a bit rotten ... it still features endland the number of whitespace changes is as huge as the time when auto-formatting was the new hot thing 🤣 so that seems not an easy task. Any ideas how to solve that mess?

Jens-G avatar Aug 28 '24 20:08 Jens-G

solve that mess?

Well, first declare Python2 officialy unsupported and let vultures tear it appart apiece ;-)

From what I've seen the "one mega PR" approach usualy never completes. At some point people suggests to add typign annotation ;-)

a-detiste avatar Aug 28 '24 20:08 a-detiste

we probably should consider this PR part of THRIFT-5537 (add that to PR/commit message title)?

fishy avatar Aug 28 '24 20:08 fishy

would love to see python2 removed but don't have time or bandwidth to actually test it to make it solid.

  • https://github.com/apache/thrift/pull/2588 if anyone's interested feel free to take over

jimexist avatar Aug 29 '24 02:08 jimexist