thrift icon indicating copy to clipboard operation
thrift copied to clipboard

THRIFT-5638: [java][lib] use check not test in gradle

Open jimexist opened this issue 3 years ago • 3 comments
trafficstars

use check not test in gradle

  • [x] Did you create an Apache Jira ticket? (not required for trivial changes)
  • [x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • [x] Did you squash your changes to a single commit? (not required, but preferred)
  • [x] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • [x] If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

jimexist avatar Sep 23 '22 07:09 jimexist

this test fails because ktfmt-gradle actually will check for generated-sources dir but we'd like to exclude that for checking but not for compilation

jimexist avatar Sep 24 '22 01:09 jimexist

this test fails because ktfmt-gradle actually will check for generated-sources dir but we'd like to exclude that for checking but not for compilation

i put up the fix: to put the generated sources to test source set which resolves the issue

jimexist avatar Sep 25 '22 04:09 jimexist

I don't know enough about Gradle to understand the differences between test and check, but don't see anything to object to here.

note to myself: currently this is still failing because the gradle check will include spotless check on generated java files. there's no easy way to filter them out unless changes are to be made in the gradle plugin.

jimexist avatar Oct 25 '22 14:10 jimexist