systemds icon indicating copy to clipboard operation
systemds copied to clipboard

Published 20 hours ago • verified publisher icon apache

Optimization of I/O path of python interface

Open cs-ally opened this issue 1 year ago • 2 comments

cs-ally avatar Jun 16 '24 10:06 cs-ally

Hi @cs-ally

Thanks for the PR.

Before I go into details on the PR, I suggest you address the failing test cases in the Python API. The log indicates that they relate to your implementation.

Best regards Sebastian

Baunsgaard avatar Jun 18 '24 09:06 Baunsgaard

Welcome to Codecov :tada:

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered :open_umbrella:

codecov-commenter avatar Jul 04 '24 18:07 codecov-commenter

processing_times_comparison Processing time improvement visualisation

cs-ally avatar Jul 14 '24 12:07 cs-ally

processing_times_comparison Processing time improvement visualisation

great, good results. The plot can be improved by marking relative speedup as in 5x faster etc. It would be good if we can have the old implementation as a fall back solution in the cases with many columns, to not have any speed downs.

Baunsgaard avatar Jul 15 '24 08:07 Baunsgaard

Screenshot 2024-07-27 at 22 19 52

cs-ally avatar Jul 28 '24 11:07 cs-ally

Merging in #2065 , Thanks for the contribution @cs-ally While merging I fix the remaining issues, with tabs vs spaces and such.

Baunsgaard avatar Aug 15 '24 10:08 Baunsgaard