superset
superset copied to clipboard
fix(Dashboard): Retain colors when color scheme not set
SUMMARY
This PR does the following:
- It fixes an issue for which colors would sometimes not keep their consistency when leaving and revisiting the Dashboard.
- It fixes an issue for which charts original color schemes were not tracked making falling back to their origin color scheme impossible when removing the color scheme from the Dashboard.
- It attempts to fix and re-enable skipped E2E tests that are critical for the coverage of the color consistency implementation.
BEFORE
https://github.com/user-attachments/assets/d66e66ff-13ec-4bb1-a1bf-72f6afcd1bfc
AFTER
https://github.com/user-attachments/assets/fd74e76e-ea20-4d89-8f05-49455bcb5fd0
TESTING INSTRUCTIONS
- Open a Dashboard with a color scheme and shared label colors
- Edit the Dashboard properties and remove the color scheme
- After applying the changes, verify that shared label colors are still respected
- For charts that do not share labels, verify their original color scheme is respected
- Save and exit the Dashboard by going to the Dashboard lists
- Come back again to the same Dashboard you just saved
- Make sure colors haven't changed from the previous state
ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in SIP-59)
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
Upvote for this. This problem is annoying.
OMG thank you!
I will try to tackle an issue for which after deleting a color scheme from a Dashboard and then editing the Chart from the Dashboard, Explore won't allow to customize the color.
/testenv up
@kgabryje Ephemeral environment spinning up at http://35.93.185.64:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.