superset icon indicating copy to clipboard operation
superset copied to clipboard

Published 20 hours ago • verified publisher icon apache

Export full CSV downloads only first page with pagination enabled on table chart

Open mdeshmu opened this issue 3 years ago • 3 comments
trafficstars

When multiple pages are present in a table chart and user clicks on Export full CSV, only the data from first page is getting exported in CSV.

How to reproduce the bug

  1. Go to 'Dashboard'
  2. Click on 'Export full CSV' on a table chart
  3. A zip should be downloaded
  4. Analyze csv file to see only first page of the table downloaded

Expected results

CSV file with entries from all pages should get downloaded.

Actual results

CSV file with entries of first page getting downloaded

Screenshots

image

server-pagination

Environment

  • browser type and version: Chrome Version 103.0.5060.114 (Official Build) (64-bit)
  • superset version: 1.5.1
  • python version: 3.8.12
  • node.js version:
  • any feature flags active: ALLOW_FULL_CSV_EXPORT

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • [ ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • [x] I have reproduced the issue with at least the latest released version of superset.
  • [x] I have checked the issue tracker for the same issue and I haven't found one similar.

mdeshmu avatar Jul 15 '22 13:07 mdeshmu

@LahmerIlyas can you please create a PR for this one just like we discussed in 17861

mdeshmu avatar Jul 17 '22 12:07 mdeshmu

@mdeshmu I would be glad to help with a solution to this issue.

LahmerIlyas avatar Jul 17 '22 13:07 LahmerIlyas

@LahmerIlyas did you get time to look into this?

mdeshmu avatar Sep 14 '22 02:09 mdeshmu

@LahmerIlyas ping! cc: @rusackas @michael-s-molina

mdeshmu avatar Feb 03 '23 13:02 mdeshmu

@mdeshmu sorry for taking too long on this. I created a PR for a fix for the issue. You can see it here: https://github.com/apache/superset/pull/23554

LahmerIlyas avatar Apr 03 '23 02:04 LahmerIlyas

@geido Can we get a review for my PR please.

LahmerIlyas avatar Apr 03 '23 02:04 LahmerIlyas

Thanks @LahmerIlyas

mdeshmu avatar Apr 03 '23 18:04 mdeshmu

I just came across this issue and PR again. Maybe I'm taking crazy pills, but I couldn't get reproduce this issue on current master. Is it still a problem on master or did some other PR resolve it in some other way?

rusackas avatar Apr 15 '23 04:04 rusackas

I just came across this issue and PR again. Maybe I'm taking crazy pills, but I couldn't get reproduce this issue on the current master. Is it still a problem on master or did some other PR resolve it in some other way?

@rusackas Thanks for testing. I just managed to reproduce it on the master branch. Here is a recording:

USA-Births-Names.webm

LahmerIlyas avatar Apr 15 '23 05:04 LahmerIlyas

@mdeshmu sorry for taking too long on this. I created a PR for a fix for the issue. You can see it here: #23554

@LahmerIlyas hi，I hava same issues, I modified the local code according to #23554,and enable ALLOW_FULL_CSV_EXPORT flag,I exported all the data when I used Export FULL CSV and Export CSV,The value of variable formDataCopy.result_type is full. Is this a normal result? Thanks you~

hzdx943 avatar May 31 '23 10:05 hzdx943

@mdeshmu sorry for taking too long on this. I created a PR for a fix for the issue. You can see it here: #23554

@LahmerIlyas hi,After applying this modification,I have encountered a new problem,The data refreshed after clicking on the page number will always be the data from the first page！

hzdx943 avatar Jun 02 '23 09:06 hzdx943

Closing this one as stale. Related to #17861

geido avatar Feb 22 '24 17:02 geido