subversion icon indicating copy to clipboard operation
subversion copied to clipboard

[PATCH] enhance check-mime-type.pl: also check property-modified files

Open maddes-b opened this issue 5 years ago • 5 comments

[[[ Enhance hook script check-mime-type.pl to also check property-modified files.

  • contrib/hook-scripts/check-mime-type.pl:
    • add option to recognize property-modified files for checks
    • make check for svn:eol-style optional
    • enhance texts and comments to reflect changes
    • rename array "files_added" to "files_to_check" to better fit its usage
    • explicitly mark here document with quotes as interpolating
    • fix script name in comments
    • update copyright and license to reflect switch to ASF

Patch by: Matthias Bücher [email protected] Suggested by: Leo Davis [1]

[1] https://mail-archives.apache.org/mod_mbox/subversion-dev/201403.mbox/%[email protected]%3E ]]]

maddes-b avatar Sep 07 '20 18:09 maddes-b

Hello, Please could you discuss this PR on our dev@ mailing list (dev {at} subversion.apache.org) - see https://subversion.apache.org/mailing-lists.html. Attach the patches (either in Git or SVN format) with a .txt extension to your mail. Thanks!

hartmannathan avatar Sep 07 '20 19:09 hartmannathan

See discussion thread and review at https://lists.apache.org/thread.html/red026ebd7412691b03eb95468993c222dea64443a427be75b2509946%40%3Cdev.subversion.apache.org%3E

hartmannathan avatar Sep 14 '20 13:09 hartmannathan

Hi there, sorry for the long delay. I read dev list comments and will re-write history of this pull request. Give me next weekend. Kind regards

maddes-b avatar Nov 01 '20 16:11 maddes-b

Hi there, sorry for the long delay. I read dev list comments and will re-write history of this pull request. Give me next weekend. Kind regards

Thanks! No worries.

hartmannathan avatar Nov 01 '20 17:11 hartmannathan

Updated the PR with the changes I send to the mailing list on 2020-12-21 16:22 CET. Had to rewrite history. Change is now commit 0b45e1736c2bfe88c54e5c8580b46a5ed53b4dac. Updated issue title and top post to reflect the changes.

maddes-b avatar Jan 02 '21 19:01 maddes-b

您的来信已收到

MarsrockEarth avatar Aug 26 '23 14:08 MarsrockEarth

@maddes-b Thanks for your patch, committed in r1911931. Sorry for the long delay in getting this sorted!

dsahlberg-apache-org avatar Aug 26 '23 14:08 dsahlberg-apache-org