storm icon indicating copy to clipboard operation
storm copied to clipboard

[STORM-3850] Static code analyzer (PMD) Errors

Open jira-importer opened this issue 3 years ago • 1 comments

Static Code Analyzer (using PMD plugin) reports a large number of errors.

Many of them are parsing errors by PMD plugin itself. This appears to be because the parse is assuming that the target source is below JDK 1.6.

(1) Fix this to assume JDK 1.8 source so that method references are properly parsed.
(2) Fix the java code to remove PMD warnings

Changing the code to 1.8 may reveal new PMC exceptions that were hidden because of PMD plugin parser errors.

(3) Fix new java code PMD errors uncovered when target jdk is switched to jdk8 and even jdk11


Originally reported by bipinprasad, imported from: Static code analyzer (PMD) Errors
  • assignee: bipinprasad
  • status: In Progress
  • priority: Major
  • resolution: Unresolved
  • imported: 2025-01-24

jira-importer avatar Apr 04 '22 21:04 jira-importer

bipinprasad:

Files with PMD Errors:

storm/examples/storm-kafka-client-examples/src/main/java/org/apache/storm/kafka/bolt/KafkaProducerTopology.java:
storm/examples/storm-loadgen/src/main/java/org/apache/storm/loadgen/CaptureLoad.java:
storm/examples/storm-perf/src/main/java/org/apache/storm/perf/queuetest/JCQueuePerfTest.java:
storm/examples/storm-pmml-examples/src/main/java/org/apache/storm/pmml/JpmmlRunnerTestTopology.java:
storm/examples/storm-starter/src/jvm/org/apache/storm/starter/LambdaTopology.java:
storm/external/storm-blobstore-migration/src/main/java/org/apache/storm/blobstore/MigrateBlobs.java:
storm/external/storm-cassandra/src/main/java/org/apache/storm/cassandra/query/builder/ObjectMapperCqlStatementMapperBuilder.java:
storm/external/storm-elasticsearch/src/test/java/org/apache/storm/elasticsearch/common/EsConfigTest.java:
storm/external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/bolt/EventHubBolt.java:
storm/external/storm-hdfs/src/test/java/org/apache/storm/hdfs/bolt/AvroGenericRecordBoltTest.java:
storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/bolt/KafkaBolt.java:
storm/external/storm-pmml/src/main/java/org/apache/storm/pmml/model/ModelOutputs.java:
storm/external/storm-solr/src/main/java/org/apache/storm/solr/mapper/SolrMapper.java:
storm/flux/flux-core/src/main/java/org/apache/storm/flux/parser/FluxParser.java:
storm/integration-test/src/main/java/org/apache/storm/st/topology/window/TimeDataVerificationBolt.java:
storm/sql/storm-sql-core/src/test/org/apache/storm/sql/SqlTestUtil.java:
storm/storm-client/src/jvm/org/apache/storm/blobstore/BlobStore.java:
storm/storm-core/src/jvm/org/apache/storm/command/AdminCommands.java:
storm/storm-server/src/main/java/org/apache/storm/blobstore/LocalFsBlobStore.java:
storm/storm-webapp/src/main/java/org/apache/storm/daemon/common/JsonResponseBuilder.java:

jira-importer avatar Apr 04 '22 23:04 jira-importer