spark icon indicating copy to clipboard operation
spark copied to clipboard

[SPARK-42307][SQL][BUILD][DOCS] Adding in a better name for `_LEGACY_ERROR_TEMP_2232`

Open hannahkamundson opened this issue 1 year ago • 4 comments

What changes were proposed in this pull request?

This adds a better name for the error type _LEGACY_ERROR_TEMP_2232 and updates the messages for it.

Why are the changes needed?

All that was changed was the

  • name for _LEGACY_ERROR_TEMP_2232 to NULL_ROW_VALUE
  • sqlState for _LEGACY_ERROR_TEMP_2232
  • message for _LEGACY_ERROR_TEMP_2232

Does this PR introduce any user-facing change?

Yes.

  • It updates the sqlState for _LEGACY_ERROR_TEMP_2232 to 2200E whereas it was previously empty.
  • It updates the message for _LEGACY_ERROR_TEMP_2232 from Value at index <index> is null. to Row value at the position <index> is NULL.

How was this patch tested?

Unit tests

Was this patch authored or co-authored using generative AI tooling?

No

hannahkamundson avatar Dec 13 '23 20:12 hannahkamundson

@hannahkamundson Could you add a test for the error class, please.

MaxGekk avatar Dec 14 '23 19:12 MaxGekk

@MaxGekk Let me know what you think!

hannahkamundson avatar Dec 20 '23 21:12 hannahkamundson

@MaxGekk Any thoughts?

hannahkamundson avatar Jan 02 '24 20:01 hannahkamundson

@MaxGekk Rebased on master. I can make the changes above. I just need a little more guidance :)

hannahkamundson avatar Jan 21 '24 20:01 hannahkamundson

We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!

github-actions[bot] avatar May 05 '24 00:05 github-actions[bot]