spark icon indicating copy to clipboard operation
spark copied to clipboard

[SPARK-37599][SQL][TESTS] Unify v1 and v2 ALTER TABLE .. SET LOCATION tests

Open panbingkun opened this issue 3 years ago • 2 comments

What changes were proposed in this pull request?

  • Move parser tests from DDLParserSuite to AlterTableSetLocationParserSuite.
  • Port DS v1 tests from DDLSuite and other test suites to v1.AlterTableSetLocationSuite.
  • Add a test for DSv2 ALTER TABLE .. SET SERDE to v2.AlterTableSetLocationSuite.

Why are the changes needed?

To improve test coverage.

Does this PR introduce any user-facing change?

No

How was this patch tested?

By running new test suites:

$ build/sbt -Phive-2.3 -Phive-thriftserver "test:testOnly *AlterTableSetLocationSuite" $ build/sbt -Phive-2.3 -Phive-thriftserver "test:testOnly *AlterTableSetLocationParserSuite"

panbingkun avatar Aug 02 '22 08:08 panbingkun

Can one of the admins verify this patch?

AmplabJenkins avatar Aug 02 '22 15:08 AmplabJenkins

cc @MaxGekk

panbingkun avatar Aug 03 '22 11:08 panbingkun

+1, LGTM. Merging to master. Thank you, @panbingkun.

MaxGekk avatar Aug 14 '22 16:08 MaxGekk