spark-kubernetes-operator icon indicating copy to clipboard operation
spark-kubernetes-operator copied to clipboard

[SPARK-49331][FOLLOWUP] Fix `cpu` to `cpus` in `setup-minikube` setting

Open dongjoon-hyun opened this issue 1 year ago • 4 comments

What changes were proposed in this pull request?

This PR is a follow-up of the following PR to fix cpu to cpus in setup-minikube setting.

  • #82

Why are the changes needed?

This was a typo and CI complains like the following.

  • https://github.com/apache/spark-kubernetes-operator/actions/runs/10503328332/job/29096477836
Warning: Unexpected input(s) 'cpu', valid inputs are ['start', 'cache', 'minikube-version', 'driver', 'container-runtime', 'kubernetes-version', 'cpus', 'memory', 'network-plugin', 'cni', 'addons', 'extra-config', 'feature-gates', 'listen-address', 'mount-path', 'install-path', 'wait', 'insecure-registry', 'start-args']

Does this PR introduce any user-facing change?

No, this is an infra bug fix.

How was this patch tested?

Manually check the CI logs.

Was this patch authored or co-authored using generative AI tooling?

No.

dongjoon-hyun avatar Aug 22 '24 07:08 dongjoon-hyun

cc @TQJADE

dongjoon-hyun avatar Aug 22 '24 07:08 dongjoon-hyun

Thank you, @TQJADE .

dongjoon-hyun avatar Aug 22 '24 07:08 dongjoon-hyun

For your Spark PR, I fixed it.

dongjoon-hyun avatar Aug 22 '24 07:08 dongjoon-hyun

Could you review this PR, @viirya ?

dongjoon-hyun avatar Aug 22 '24 15:08 dongjoon-hyun

Looks good to me.

viirya avatar Aug 22 '24 16:08 viirya

Thank you! Merged to main.

dongjoon-hyun avatar Aug 22 '24 16:08 dongjoon-hyun