solr icon indicating copy to clipboard operation
solr copied to clipboard

Published 20 hours ago • verified publisher icon apache

SOLR-15831: Refactor bin/solr and bin/solr.cmd to delegate args parsing and usage help to SolrCLI

Open thelabdude opened this issue 3 years ago • 3 comments

https://issues.apache.org/jira/browse/SOLR-15831

Start of some much needed clean-up of the bin/solr scripts! In this PR, I'm mainly removing usage information from the OS specific scripts (bin/solr and bin\solr.cmd) and instead delegating the usage output to the SolrCLI Java code. There's no reason to maintain command usage info in 3 places!

thelabdude avatar Jan 07 '22 18:01 thelabdude

Boy I wish I had seen this PR a long time ago... A lot of good stuff in here...

epugh avatar Oct 05 '23 21:10 epugh

Hey @thelabdude I went through this PR, and I think at this point I've combed out all the good stuff in this PR already and have committed them in various PR's. Are you comfortable with me closing this PR to tidy up our list? (Also cause I keep re-reading it every few weeks thinking that I missed an inprogress PR!).

epugh avatar Oct 06 '23 01:10 epugh

Assigning to myself to do one more pass through for pulling "the good stuff out" and then will close it.

epugh avatar Jun 19 '24 18:06 epugh

Some of the ideas in this PR ended up in #2545 as well. I am going to look a bit more at how PackageTool does it's extended help information, and see if we can use that approach more in other tools, and reduce what's in bin/solr and bin/solr.cmd.

epugh avatar Jul 21 '24 09:07 epugh

I believe I've pulled all the good stuff into the new PR #2580 . @thelabdude would love any review ;-)!

epugh avatar Jul 22 '24 11:07 epugh