solr icon indicating copy to clipboard operation
solr copied to clipboard

SOLR-17109: Give security manager explicit read access to sharedLib

Open tflobbe opened this issue 1 year ago • 6 comments

tflobbe avatar Jan 02 '24 17:01 tflobbe

This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify the [email protected] mailing list. Thank you for your contribution!

github-actions[bot] avatar Mar 07 '24 00:03 github-actions[bot]

This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify the [email protected] mailing list. Thank you for your contribution!

github-actions[bot] avatar May 15 '24 00:05 github-actions[bot]

Can someone explain the future of security manager in Java to me? My understanding is that it is going away (and no replacement??)... So, wouldn't it be better just to deprecate the security manager now, and NOT rely on it?

epugh avatar May 15 '24 12:05 epugh

Also, @dsmiley looks like you approved this change, can we go ahead and get it merged?

epugh avatar May 15 '24 12:05 epugh

I'm fine with merging this. @janhoy's comment is valid though, it would cause issues if solr.sharedLib has more than one directory

tflobbe avatar May 15 '24 13:05 tflobbe

I'm fine with merging this. @janhoy's comment is valid though, it would cause issues if solr.sharedLib has more than one directory

do you want me to do it? Or I can leave it up to you. I just love seeing PR's and tickets close ;-)

epugh avatar May 15 '24 13:05 epugh

I wish we had some bats style tests for these things ;-). I'm going to merge this when the tests finish.

epugh avatar Jun 09 '24 14:06 epugh

https://issues.apache.org/jira/browse/SOLR-17109

epugh avatar Jun 09 '24 14:06 epugh