shiro
shiro copied to clipboard
apache
Implement SaltStyle.CRYPT
Implement SaltStyle.CRYPT fro the JdbcRealm. Add some basic tests.
Digging up this old PR, I recently implemented a shiro2 crypto format, which is based on the unix formats and uses the same identifiers. Maybe we can use those here, too? @bdemers ?
@bmarwell that sounds like a great idea!
Also, @manticore-projects, my previous review message seems a bit harsh when looking back at it. Sorry about that! I should have started with a Thank you for sending us that PR!
Also, @manticore-projects, my previous review message seems a bit harsh when looking back at it. Sorry about that! I should have started with a Thank you for sending us that PR!
No big deal and all good. If is is not threadsafe, we need to deal with it and when you point me on the line of code or illustrate your concern, I would work on it. (I know what threadsafe means, but I did not see how two threads would interfere here.)
Ok, how about: Let's open an issue over at https://issues.apache.org/jira/browse/SHIRO, describe the idea behind this PR in general, rebase it, use the new crypto classes, and get it into 2.0.x? :)