rocketmq icon indicating copy to clipboard operation
rocketmq copied to clipboard

[ISSUE #8682] Add more test coverage for TopicRouteInfoManager

Open yx9o opened this issue 1 year ago • 3 comments

Fixes #8682 .

yx9o avatar Sep 11 '24 14:09 yx9o

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 47.55%. Comparing base (d3e5f70) to head (53aa28b).

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #8683   +/-   ##
==========================================
  Coverage      47.54%   47.55%           
- Complexity     11548    11552    +4     
==========================================
  Files           1277     1277           
  Lines          89457    89457           
  Branches       11505    11505           
==========================================
+ Hits           42535    42543    +8     
+ Misses         41712    41681   -31     
- Partials        5210     5233   +23     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Sep 11 '24 15:09 codecov-commenter

CR need

Please tell me where I need to modify. I don't understand.

yx9o avatar Sep 20 '24 08:09 yx9o

Hi @ShannonDing , please help review, thank you.

yx9o avatar Oct 10 '24 01:10 yx9o

Hi @RongtongJin , please help review, thank you.

yx9o avatar Oct 28 '24 08:10 yx9o

This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR.

github-actions[bot] avatar Nov 13 '25 00:11 github-actions[bot]

This PR was closed because it has been inactive for 3 days since being marked as stale.

github-actions[bot] avatar Nov 16 '25 00:11 github-actions[bot]