rocketmq icon indicating copy to clipboard operation
rocketmq copied to clipboard

Fix: instance was created prematurely

Open oopooa opened this issue 1 year ago • 2 comments
trafficstars

Which Issue(s) This PR Fixes

Fixes #8456

Brief Description

ensure the instance is created at the right moment

How Did You Test This Change?

oopooa avatar Jul 26 '24 18:07 oopooa

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 45.86%. Comparing base (304987d) to head (0f1d2af).

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8457      +/-   ##
=============================================
- Coverage      45.92%   45.86%   -0.07%     
+ Complexity     11104    11092      -12     
=============================================
  Files           1274     1274              
  Lines          89001    89001              
  Branches       11441    11441              
=============================================
- Hits           40875    40820      -55     
- Misses         43027    43078      +51     
- Partials        5099     5103       +4     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jul 26 '24 18:07 codecov-commenter

Hi @RongtongJin

I noticed that this PR has been open for a while and wanted to check if there's anything more I can do to help get it merged. Please let me know if there are any changes or additional information needed.

Thanks!

oopooa avatar Aug 01 '24 08:08 oopooa